Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shrink _ASPendingState from 824 to 808 bytes, reduction of ~2% #1483

Merged
merged 2 commits into from
May 7, 2019
Merged

Shrink _ASPendingState from 824 to 808 bytes, reduction of ~2% #1483

merged 2 commits into from
May 7, 2019

Commits on May 3, 2019

  1. Shrink _ASPendingState from 824 to 808 bytes, reduction of ~2% 

    These objects accumulate in the heap, so reducing their size will allow more to accumulate before memory warnings.

Shrink ASPendingState BOOLs. Use unsigned int for these bitfields for clarity. Separate from `_flags` as that struct is compared to `0` for testing. The `_boolFlags` struct is just storing other `BOOL`s.
    Greg Bolsinga committed May 3, 2019
    Configuration menu
    Copy the full SHA
    6b58a8c View commit details
    Browse the repository at this point in the history

  2. rename struct fields as suggested in garret's review.

    Greg Bolsinga committed May 3, 2019
    Configuration menu
    Copy the full SHA
    865e6a0 View commit details
    Browse the repository at this point in the history