[feat] Added download progress for NetworkImageNode #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
requested changes
Jun 27, 2019
Source/ASNetworkImageNode.h
Outdated
| @@ -133,6 +133,13 @@ NS_ASSUME_NONNULL_BEGIN | |||
| */ | |||
| @property (readonly) CGFloat renderedImageQuality; | |||
|
|
|||
| /** | |||
| * Loading progress of the current image. | |||
There was a problem hiding this comment.
Let's call it "download progress" to be a bit clearer and consistent with PINRemoteImage.
Suggested change
| * Loading progress of the current image. | |
| * Download progress of the current image. |
Source/ASNetworkImageNode.h
Outdated
| @@ -133,6 +133,13 @@ NS_ASSUME_NONNULL_BEGIN | |||
| */ | |||
| @property (readonly) CGFloat renderedImageQuality; | |||
|
|
|||
| /** | |||
| * Loading progress of the current image. | |||
| * When downloading a network image, this value would be updated to track downloading progress. ( number between 0.0 and 1.0 ) | |||
There was a problem hiding this comment.
Suggested change
| * When downloading a network image, this value would be updated to track downloading progress. ( number between 0.0 and 1.0 ) | |
| * When downloading a network image, this value would be updated to track download progress (value between 0 and 1) |
Source/ASNetworkImageNode.h
Outdated
| /** | ||
| * Loading progress of the current image. | ||
| * When downloading a network image, this value would be updated to track downloading progress. ( number between 0.0 and 1.0 ) | ||
| * If the URL is unset, this is 1.0 if defaultImage or image is set to non-nil. |
There was a problem hiding this comment.
Suggested change
| * If the URL is unset, this is 1.0 if defaultImage or image is set to non-nil. | |
| * If the URL is unset, this is 1 if defaultImage or image is set to non-nil. |
Source/ASNetworkImageNode.mm
Outdated
| return ASLockedSelf(_loadingProgress); | ||
| } | ||
|
|
||
| - (void)_locked_setLoadingProgress:(CGFloat)loadingProgress |
There was a problem hiding this comment.
Let's add an explanation why we're dispatching to the main queue here. Something similar to what _setCurrentImageQuality has.
Source/ASNetworkImageNode.mm
Outdated
| return ASLockedSelf(_loadingProgress); | ||
| } | ||
|
|
||
| - (void)_locked_setLoadingProgress:(CGFloat)loadingProgress |
There was a problem hiding this comment.
Suggested change
| - (void)_locked_setLoadingProgress:(CGFloat)loadingProgress | |
| - (void)_setDownloadProgress:(CGFloat)downloadProgress |
Source/ASNetworkImageNode.h
Outdated
| * When downloading a network image, this value would be updated to track downloading progress. ( number between 0.0 and 1.0 ) | ||
| * If the URL is unset, this is 1.0 if defaultImage or image is set to non-nil. | ||
| */ | ||
| @property (readonly) CGFloat loadingProgress; |
There was a problem hiding this comment.
Suggested change
| @property (readonly) CGFloat loadingProgress; | |
| @property (readonly) CGFloat downloadProgress; |
|
@nguyenhuy I renamed to |
nguyenhuy
requested changes
Jul 19, 2019
Source/ASNetworkImageNode.mm
Outdated
| if (strongSelf == nil) { | ||
| return; | ||
| } | ||
| [strongSelf _updateDownloadedProgress:progress downloadIdentifier:downloadIdentifier]; |
There was a problem hiding this comment.
I think this is a bit more concise.
if (strongSelf != nil) {
[strongSelf _updateDownloadedProgress:progress downloadIdentifier:downloadIdentifier];
}
Source/ASNetworkImageNode.mm
Outdated
| @@ -768,6 +817,7 @@ - (void)_lazilyLoadImageIfNecessary | |||
| UIImage *newImage; | |||
| if (imageContainer != nil) { | |||
| [strongSelf _setCurrentImageQuality:1.0]; | |||
| [self _setDownloadProgress:1.0]; | |||
There was a problem hiding this comment.
This is the only remaining blocker for this PR!
Suggested change
| [self _setDownloadProgress:1.0]; | |
| [strongSelf _setDownloadProgress:1.0]; |
There was a problem hiding this comment.
😢 Seems I just do the copied. Thanks! 👍
nguyenhuy
approved these changes
Jul 20, 2019
nguyenhuy
approved these changes
Jul 23, 2019
Source/ASNetworkImageNode.h
Outdated
| /** | ||
| * Download progress of the current image. | ||
| * When downloading a network image, this value would be updated to track download progress (value between 0 and 1) | ||
| * If the URL is unset, this is 1 if defaultImage or image is set to non-nil. |
There was a problem hiding this comment.
If the URL is unset, this is 1 if defaultImage or image is set to non-nil.
This line is not true for download progress because the progress should be 0 (set here).
Source/ASNetworkImageNode.mm
Outdated
| } | ||
|
|
||
| /** | ||
| * Always use these methods internally to update the current image quality |
There was a problem hiding this comment.
Suggested change
| * Always use these methods internally to update the current image quality | |
| * Always use these methods internally to update the current download progress |
There was a problem hiding this comment.
Nice catch! Thanks! 👍
|
@nguyenhuy Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, seems we don't have any property to observe download progress, it's useful for user who can handle progress things(like progress indicator) by observing download progress.