Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for basic ASTextNode2 link highlighting #1518

Merged
merged 6 commits into from
Jun 3, 2019
Merged

Add support for basic ASTextNode2 link highlighting #1518

merged 6 commits into from
Jun 3, 2019

Conversation

maicki
Copy link
Contributor

@maicki maicki commented May 25, 2019 •
edited
Loading

Current shortcomings that will be addressed in follow up work:

  • If link goes over multiple lines the highlighting starting line two will go in certain circumstances if the link is truncated in a unfortunate case to the end of the line
  • As we are searching the 9 points of a 44x44 square around the touch until we find a link, links could be highlighted that are not visible.

@TextureGroup TextureGroup deleted a comment May 26, 2019
@TextureGroup TextureGroup deleted a comment May 28, 2019
@TextureGroup TextureGroup deleted a comment May 28, 2019
@TextureGroup TextureGroup deleted a comment May 28, 2019
Adlai-Holler
Adlai-Holler reviewed May 28, 2019
View reviewed changes
Source/ASTextNode.mm Show resolved Hide resolved
Source/ASTextNode2.mm Show resolved Hide resolved
Source/Private/TextExperiment/Component/ASTextLayout.mm Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented May 29, 2019

🚫 CI failed with log

@maicki
Copy link
Contributor Author

maicki commented May 29, 2019

@nguyenhuy Can you please trigger a new test build. Thanks!

@maicki maicki requested a review from nguyenhuy May 29, 2019 22:02
@maicki
Copy link
Contributor Author

maicki commented May 30, 2019

@Adlai-Holler Can you give that another look please. Thanks!

@Adlai-Holler Adlai-Holler merged commit ab8ea06 into master Jun 3, 2019
@Adlai-Holler Adlai-Holler deleted the MSASTextNode2Highlighting branch June 3, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adlai-Holler Adlai-Holler Adlai-Holler approved these changes

@appleguy appleguy Awaiting requested review from appleguy

@nguyenhuy nguyenhuy Awaiting requested review from nguyenhuy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maicki @Adlai-Holler