Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes UIKit version of ASDKGram #1521

Merged
merged 2 commits into from
May 29, 2019
Merged

Fixes UIKit version of ASDKGram #1521

merged 2 commits into from
May 29, 2019

Conversation

maicki
Copy link
Contributor

@maicki maicki commented May 28, 2019

Fixes:

  • Image cache which didn't add the image to the cache after fetching
  • Remove image caching restrictions of 10 to default value of NSCache
  • Layout issues
  • Image overlap with UIViewContentModeScaleAspectFill
  • Set an image for an old model although a new model was already set
  • Fixes description size calculation
  • Used USE_UIKIT_PROGRAMMATIC_LAYOUT instead of USE_UIKIT_MANUAL_LAYOUT
  • Project wide indentation
  • Improved performance

@maicki maicki requested a review from nguyenhuy May 28, 2019 14:37
@TextureGroup TextureGroup deleted a comment May 29, 2019
@maicki maicki requested a review from Adlai-Holler May 29, 2019 14:39
@maicki maicki merged commit a2abd00 into master May 29, 2019
@maicki maicki deleted the MSFixesASDKGramUIKit branch July 5, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adlai-Holler Adlai-Holler Adlai-Holler approved these changes

@nguyenhuy nguyenhuy Awaiting requested review from nguyenhuy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maicki @Adlai-Holler