Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASTextNode2] Fix truncation token is wrong after attributed string is changing with different foreground color #1550

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

maicki
Copy link
Contributor

@maicki maicki commented Jun 12, 2019

No description provided.

@maicki maicki requested a review from Adlai-Holler June 12, 2019 14:41
@ghost
Copy link

ghost commented Jun 12, 2019

🚫 CI failed with log

@maicki maicki force-pushed the MSFixTruncationTokenColorASTextNode2 branch from 7e7c1e2 to aad6e3f Compare June 13, 2019 14:45
Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still relevant after your work inside of +layoutWithContainer?

@maicki
Copy link
Contributor Author

maicki commented Jun 26, 2019

Yes that is still needed. +layoutWithContainer will follow in a future PR.

@maicki maicki merged commit 18e5527 into master Jul 2, 2019
@maicki maicki deleted the MSFixTruncationTokenColorASTextNode2 branch July 5, 2019 18:30
harryworld added a commit to harryworld/Texture that referenced this pull request Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants