Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASDataController] Add an experiment that avoids flushing editing queue before starting the data pipeline pipeline #1564

Merged
merged 4 commits into from
Jul 1, 2019

Commits on Jun 27, 2019

  1. [ASDataController] Avoid flushing editing queue before starting data …

    …controller pipeline
    
    Step 1 of the pipeline is on main thread and needs pendingMap which was updated by the end of step 1 of the run. And step 1 operates on data source index space. So it should be ok to start it ASAP -- without waiting for any running work on the background editing queue.
    
    One potential race condition after this change is that it's possible for main thread to query the data source (step 1) while the editing queue consumes the last change set (step 3). However, as long as the client's each nodeBlock and the node's layout code capture/reference an individual model object (as opposed to the whole data set) -- which is what clients are supposed to do anyways, then everything should be fine.
    
    The benefit of this diff is that the pipeline will be able to accept many more change sets within a short time window, for example when clients submit a burst of separate small updates.
    
    I tested this diff against our test suite several times and smoke tested it in our code base without any issues.
    nguyenhuy committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    95892dc View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2019

  1. Wrap in an experiment

    nguyenhuy committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    f1296a8 View commit details
    Browse the repository at this point in the history
  2. Enable experiment in tests

    nguyenhuy committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    8a5e16b View commit details
    Browse the repository at this point in the history
  3. Minor change

    nguyenhuy committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    5619fd8 View commit details
    Browse the repository at this point in the history