Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all project coding warnings in examples folder #1582

Merged
merged 2 commits into from
Jul 28, 2019
Merged

Fix all project coding warnings in examples folder #1582

merged 2 commits into from
Jul 28, 2019

Conversation

hanton
Copy link
Contributor

@hanton hanton commented Jul 12, 2019

Fix all project coding warnings in examples folder

@ghost
Copy link

ghost commented Jul 12, 2019

🚫 CI failed with log

@hanton
Copy link
Contributor Author

hanton commented Jul 13, 2019

Could you trigger the CI again?

Because it seems the CI failing is not related to the changed code, according to the error message ^_^

** BUILD FAILED **


The following build commands failed:
	CompileAssetCatalog /Users/buildkite/ASDKDerivedData/Build/Products/Debug-iphonesimulator/Sample.app /Users/Shared/buildkite/builds/iosf-garrett-vuqKsO4.dyn.pinadmin.com-1/pinterest/texture/examples/CustomCollectionView/Sample/Images.xcassets
(1 failure)

nguyenhuy
nguyenhuy requested changes Jul 17, 2019
View reviewed changes
examples/VerticalWithinHorizontalScrolling/Sample/GradientTableNode.mm
@@ -58,7 +58,8 @@ - (ASCellNode *)tableNode:(ASTableNode *)tableNode nodeForRowAtIndexPath:(NSInde
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should migrate to the -nodeBlock data source method as well. Not a blocker for this PR though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find there're a few other example projects which also need to migrate to the -nodeBlock data source method, will create a new PR for fixing this issue altogether :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @nguyenhuy , the PR is ready at #1596

examples/VerticalWithinHorizontalScrolling/Sample/GradientTableNode.mm Outdated
@@ -58,7 +58,8 @@ - (ASCellNode *)tableNode:(ASTableNode *)tableNode nodeForRowAtIndexPath:(NSInde
{
RandomCoreGraphicsNode *elementNode = [[RandomCoreGraphicsNode alloc] init];
elementNode.style.preferredSize = _elementSize;
elementNode.indexPath = [NSIndexPath indexPathForRow:indexPath.row inSection:_pageNumber];
NSString *content = [[NSIndexPath indexPathForRow:indexPath.row inSection:_pageNumber] description];
[elementNode setContent:content];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the content is set only once, maybe pass it in as a param of the initializer and remove -setContent: altogether?

Copy link
Contributor Author

@hanton hanton Jul 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 00378ef7.

@nguyenhuy
Copy link
Member

You got a green light from CI btw.

@nguyenhuy nguyenhuy merged commit e93e666 into TextureGroup:master Jul 28, 2019
@hanton hanton deleted the fix-example-warnings branch July 31, 2019 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenhuy nguyenhuy nguyenhuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hanton @nguyenhuy