[Dev docs] Fix previous and next page links #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our pages are organized in 2 dirs: /docs/ and /development/. Within a dir, prevPage and nextPage are relative so the dir should be appended to the href link. The dir is available in permalink var. Some prevPage and nextPage point to a page in a different dir in which case they must not be relative. Instead they must include the dir and thus won't be modified.
bolsinga
approved these changes
Jul 29, 2019
mikezucc
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our pages are organized in 2 dirs:
/docs/and/development/.Within a dir,
prevPageandnextPageare relative (to the dir) so its path should be appended to their href links (see docs/_layouts/docs.html). The dir is available in the page'spermalinkvar.Some prevPage and nextPage point to a page in a different dir in which case they must not be relative. Instead they must include the other dir's path and thus their links won't be modified.
Also removed some pages that are no longer needed and fixed some
prevPageandnextPagevalues.I tested this diff locally and all links worked fine.