Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a comment bug in ASVideoNode and ASVideoPlayerNode #1604

Merged
merged 1 commit into from
Aug 4, 2019
Merged

Fix a comment bug in ASVideoNode and ASVideoPlayerNode #1604

merged 1 commit into from
Aug 4, 2019

Conversation

hanton
Copy link
Contributor

@hanton hanton commented Jul 31, 2019

Update periodicTimeObserverTimescale's comment default value to 10000, according to the real value set in the implementation.

@hanton
Update periodicTimeObserverTimescale's comment default value, accor…
331055c 
…ding to the real value set in the implementation
nguyenhuy
nguyenhuy approved these changes Aug 4, 2019
View reviewed changes
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you!

@nguyenhuy nguyenhuy merged commit 3a3e574 into TextureGroup:master Aug 4, 2019
@hanton hanton deleted the fix-ASVideoNode-ASVideoPlayerNode-comment-bug branch August 16, 2019 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenhuy nguyenhuy nguyenhuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hanton @nguyenhuy