Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep using unowned macro #1626

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

hanton
Copy link
Contributor

@hanton hanton commented Aug 20, 2019

Keep using unowned macro for code consistence, instead of using __unsafe_unretained directly.

Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@hanton
Copy link
Contributor Author

hanton commented Aug 21, 2019

hi @nguyenhuy , could you please add the CI label to this PR, so I can trigger the CI again?

@nguyenhuy
Copy link
Member

nguyenhuy commented Aug 21, 2019

Can you please rebase first? I wanted to test if adding the label alone would re-trigger the pipeline. nvm, it doesn't seem to work. Not a big deal though.

@nguyenhuy nguyenhuy merged commit 762c8e8 into TextureGroup:master Aug 23, 2019
matthewd1234 pushed a commit to matthewd1234/Texture that referenced this pull request Aug 25, 2019
@hanton hanton deleted the keep-using-unowned-macro branch August 28, 2019 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants