Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment typo for showsHorizontalScrollIndicator in ASCollectionNode #1638

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Fix comment typo for showsHorizontalScrollIndicator in ASCollectionNode #1638

merged 1 commit into from
Oct 22, 2019

Conversation

innocarpe
Copy link
Contributor

@innocarpe innocarpe commented Aug 23, 2019

There is an comment typo on ASCollectionNode's showsHorizontalScrollIndicator.

showsHorizontalScrollIndicator is initialized to YES in the ASCollectionNode's initializer.

It should be YES in ASCollectionNode.h

// ASCollectionNode.mm
- (instancetype)init
{
  self = [super init];
  if (self) {
    _rangeMode = ASLayoutRangeModeUnspecified;
    _tuningParameters = [ASAbstractLayoutController defaultTuningParameters];
    _allowsSelection = YES;
    _allowsMultipleSelection = NO;
    _inverted = NO;
    _contentInset = UIEdgeInsetsZero;
    _contentOffset = CGPointZero;
    _animatesContentOffset = NO;
    _showsVerticalScrollIndicator = YES;
    _showsHorizontalScrollIndicator = YES;
  }
  return self;
}
// ASCollectionNode.h
/**
 * A Boolean value that controls whether the horizontal scroll indicator is visible.
- * The default value of this property is NO.
+ * The default value of this property is YES.
 */
@property (nonatomic) BOOL showsHorizontalScrollIndicator;

@CLAassistant
Copy link

CLAassistant commented Aug 23, 2019

CLA assistant check
All committers have signed the CLA.

@innocarpe innocarpe changed the title [ASCollectionNode] Fix comment typo for showsHorizontalScrollIndicator Fix comment typo for showsHorizontalScrollIndicator in ASCollectionNode Aug 24, 2019
@innocarpe innocarpe closed this Sep 9, 2019
@innocarpe innocarpe reopened this Sep 9, 2019
@innocarpe innocarpe closed this Sep 9, 2019
@innocarpe innocarpe reopened this Sep 9, 2019
Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@innocarpe
Copy link
Contributor Author

@rahul-malik @maicki Thanks for review. How can I make Danger tests passed? I saw there are some PRs like me.

@vovasty
Copy link
Contributor

vovasty commented Oct 11, 2019

@innocarpe hi, please rebase the latest changes from master

@innocarpe
Copy link
Contributor Author

@vovasty Thanks for the guide. I pushed after rebasing ☺️

@vovasty vovasty merged commit a890f75 into TextureGroup:master Oct 22, 2019
@innocarpe innocarpe deleted the carpe/fix-collection-node-typo branch October 23, 2019 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants