Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup from recent changes #1647

Merged
merged 2 commits into from
Aug 28, 2019
Merged

Cleanup from recent changes #1647

merged 2 commits into from
Aug 28, 2019

Conversation

rahul-malik
Copy link
Contributor

  • Fix availability warnings for usage of userInterfaceLevel
  • Deprecate asyncTraitCollectionDidChange in favor of the new method
  • Remove old compiler warning flag added for Xcode 9 compilation
  • Access textColorFollowsTintColor with a locked scope

- Fix availability warnings for usage of userInterfaceLevel
- Deprecate `asyncTraitCollectionDidChange` in favor of the new method
- Remove old compiler warning flag added for Xcode 9 building
- Access `textColorFollowsTintColor` with a locked scope
Source/ASImageNode.mm Outdated Show resolved Hide resolved
@mikezucc
Copy link
Contributor

Will this break other devs on lower Xcodes? or should we expect them all to upgrade?

Copy link
Contributor

@bolsinga bolsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it would be terrific to know more about tvos stuff, but I don't know.

@rahul-malik
Copy link
Contributor Author

@bolsinga @mikezucc - tvOS example project added here #1649

@rahul-malik rahul-malik merged commit 6464153 into master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants