[GitHub CI] Revert back to Ruby Danger as Danger JS is not working properly #1650
Conversation
Add name to the script run phase
… for push for tests and for PR for tests + danger, run ruby danger as part of the PR check
This reverts commit 839ba3a.
There was a problem hiding this comment.
Great point on using the old Ruby file by adding a new mode to build.sh! Thank you!
I have one question: Should we just update the existing danger.yml file to run ./build.sh danger and keep ci.yml as is? That means we won't need to copy all other jobs over like what you propose in the new ci_pr.yml file?
|
For reference, #1635 introduced the Danger JS file and this PR reverts it. |
|
Actually, that's a good idea. Updated PR! |
| buildsh: | ||
| strategy: | ||
| matrix: | ||
| mode: [danger] |
There was a problem hiding this comment.
With only one configuration, using a matrix is a bit overkill since you can just configure the job directly (like this). Please feel free to follow up on another PR but not a big deal otherwise.
|
Btw, thanks again for fixing Danger! |
|
Thank you for merging it! |
danger.ymlto run as a scriptbuild.shfile and run Danger on every PRProtected branches -
Danger JSstep has to be replaced as require with theRun Dangerstep that is now working.Important:
Original Danger Ruby (implemented here) takes about 40sec where the new Danger JS that is right now on master takes about 4 mins.