use lock in asyncTraitCollectionDidChangeWithPreviousTraitCollection #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…collection change
vovasty
force-pushed
the
asimagenode-lock
branch
from
a7f61bf
to
d0eabb6
Compare
rahul-malik
reviewed
Aug 30, 2019
Source/ASImageNode.mm
Outdated
| @@ -767,6 +768,7 @@ - (void)asyncTraitCollectionDidChangeWithPreviousTraitCollection:(ASPrimitiveTra | |||
| // trigger needs display anyway, cause image might be dynamic itself (e.g. dynamic tint color) | |||
There was a problem hiding this comment.
Need to remove this or add unlock / return here
rahul-malik
approved these changes
Aug 30, 2019
mikezucc
approved these changes
Aug 30, 2019
ernestmama
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use lock to avoid crash when image might be changed during the trait collection change