Fix main thread assertion for tint color on text nodes, re-render tint-able nodes on hierarchy changes #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-malik
force-pushed
the
rmalik/textnode-tint-fixes
branch
from
218d694
to
9c95d2f
Compare
- Avoid accessing `self.tintColor` off-main since this will trigger an
assertion and might be undefined behavior
- Trigger setNeedsDisplay in cases of hierarchy change and
tintColorDidChange in ASButtonNode, ASTextNode{1,2}
- Fix bug in _ASTableViewCell where we were overwriting the tint color
instead of inheriting the correct value
- Add tests for new logic in changing hierarchy
rahul-malik
force-pushed
the
rmalik/textnode-tint-fixes
branch
from
9c95d2f
to
ce8c59f
Compare
|
@bolsinga - PTAL, this should be good to land now |
bolsinga
reviewed
Sep 14, 2019
|
Will definitely update the title / commit message. I did verify the tests fail without these changes |
Thanks for confirming! |
bolsinga
approved these changes
Sep 14, 2019
rahul-malik
changed the title
ernestmama
approved these changes
Sep 16, 2019
bolsinga
reviewed
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.tintColoroff-main since this will trigger anassertion and might be undefined behavior
tintColorDidChange in ASButtonNode, ASTextNode{1,2}
systemBlueColorif it is unable to be determined