Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1673 - Re-render Clipping Corners when User Interface Style Changes #1674

Merged
merged 2 commits into from
Sep 16, 2019
Merged

#1673 - Re-render Clipping Corners when User Interface Style Changes #1674

merged 2 commits into from
Sep 16, 2019

Commits on Sep 16, 2019

  1. This PR addresses an issue I raised with TextureGroup#1673 where the … 

    …clipping corner layer doesn't get re-rendered when going from a dark to light user interface style. The fix is to add code in the `-asyncTraitCollectionDidChangeWithPreviousTraitCollection:` method that calls through to `-_updateClipCornerLayerContentsWithRadius:backgroundColor:` if the user interface style changes.

I've also added snapshot tests to verify that using clipping corners with a dynamic background color updates when the user interface style changes.

Turn off record mode, remove errant newline

This PR addresses an issue I raised with TextureGroup#1673 where the clipping corner layer doesn't get re-rendered when going from a dark to light user interface style. The fix is to add code in the `-asyncTraitCollectionDidChangeWithPreviousTraitCollection:` method that calls through to `-_updateClipCornerLayerContentsWithRadius:backgroundColor:` if the user interface style changes.

I've also added snapshot tests to verify that using clipping corners with a dynamic background color updates when the user interface style changes.

Turn off record mode, remove errant newline
    @shamanskyh
    shamanskyh committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    7e83a2f View commit details
    Browse the repository at this point in the history

  2. Address @rahul-malik's comments

    @shamanskyh
    shamanskyh committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    a03e077 View commit details
    Browse the repository at this point in the history