Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use backgroundColor ivar instead of property access in traitCollectio… #1678

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Use backgroundColor ivar instead of property access in traitCollectio… #1678

merged 1 commit into from
Sep 18, 2019

Commits on Sep 18, 2019

  1. Use backgroundColor ivar instead of property access in traitCollectio… 

    …nDidChange

traitCollectionDidChange isn't necessarily called on Main, but our self.backgroundColor property access must be done on main once the view is loaded.

I originally opted to use self.backgroundColor rather than _backgroundColor in #1674, but I think we should use the ivar here. This could get out-of-sync if someone modified the UIView's background color instead of updating the node, but I think that's unlikely, so we should be safe to use the ivar here.
    @rahul-malik
    rahul-malik committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    b8b051b View commit details
    Browse the repository at this point in the history