fix a node background color in non layer baked mode. #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolsinga
reviewed
Oct 1, 2019
Source/ASDisplayNode.mm
Outdated
| if (!CGColorEqualToColor(_layer.backgroundColor, cgBackgroundColor)) { | ||
| _layer.backgroundColor = cgBackgroundColor; | ||
| } | ||
| } else { | ||
| // we set view and layer background color in _ASPendingState, so do the same here | ||
| if (!CGColorEqualToColor(_layer.backgroundColor, cgBackgroundColor)) { |
There was a problem hiding this comment.
Is it possible to move the color equality test up, so that the code doesn't have to be here twice?
vovasty
force-pushed
the
vlad/ASDisplayNode-background
branch
from
ac607c4
to
ed629d2
Compare
rahul-malik
approved these changes
Oct 1, 2019
bolsinga
approved these changes
Oct 1, 2019
vovasty
force-pushed
the
vlad/ASDisplayNode-background
branch
from
ed629d2
to
287747c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes problem with snapshot testing: when color is dynamic and node is not layer backed, background color remains the same.