Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new delegate methods to ASCommonTableViewDelegate for swipes #1694

Merged

Conversation

SashaZolotarev
Copy link
Contributor

  • I added new delegate methods to ASCommonTableViewDelegate:
    tableView(_:leadingSwipeActionsConfigurationForRowAt:)
    tableView(_:trailingSwipeActionsConfigurationForRowAt:)
  • And marked old method as deprecated since iOS 13.

@uuttff8
Copy link
Contributor

uuttff8 commented Mar 30, 2020

why not merge?

Copy link
Member

@jparise jparise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me (thanks!), but we should get the tests passing before we merge.

@jparise jparise force-pushed the feature/table-swipe-actions branch from 7388d17 to 2480d13 Compare March 30, 2020 16:14
@jparise jparise merged commit 9d75104 into TextureGroup:master Mar 30, 2020
@jparise
Copy link
Member

jparise commented Mar 30, 2020

Thank you, @SashaZolotarev!

piotrdebosz pushed a commit to getstoryteller/Texture that referenced this pull request Mar 1, 2021
…tureGroup#1694)

- I added new delegate methods to ASCommonTableViewDelegate:
  - tableView(_:leadingSwipeActionsConfigurationForRowAt:)
  - tableView(_:trailingSwipeActionsConfigurationForRowAt:)
- And marked old method as deprecated since iOS 13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants