Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Case where Network Image Node Stays Locked #17

Merged
merged 1 commit into from
Apr 17, 2017
Merged

Fix Case where Network Image Node Stays Locked #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Source/ASNetworkImageNode.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ - (void)didEnterPreloadState

- (void)handleProgressImage:(UIImage *)progressImage progress:(CGFloat)progress downloadIdentifier:(nullable id)downloadIdentifier
{
__instanceLock__.lock();
ASDN::MutexLocker l(__instanceLock__);

// Getting a result back for a different download identifier, download must not have been successfully canceled
if (ASObjectIsEqual(_downloadIdentifier, downloadIdentifier) == NO && downloadIdentifier != nil) {
Expand All @@ -412,8 +412,6 @@ - (void)handleProgressImage:(UIImage *)progressImage progress:(CGFloat)progress

[self _locked_setCurrentImageQuality:progress];
[self _locked__setImage:progressImage];

__instanceLock__.unlock();
}

- (void)_updateProgressImageBlockOnDownloaderIfNeeded
Expand Down