Fix for images retrieved from the memory cache being reported as disk cache hits. #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as disk (i.e. asynchronous) cache hits.
jparise
reviewed
Nov 5, 2019
Source/ASMultiplexImageNode.mm
Outdated
| @@ -806,7 +806,7 @@ - (void)_fetchImageWithIdentifierFromCache:(id)imageIdentifier URL:(NSURL *)imag | |||
| ASDisplayNodeAssertNotNil(completionBlock, @"completionBlock is required"); | |||
|
|
|||
| if (_cache) { | |||
| [_cache cachedImageWithURL:imageURL callbackQueue:dispatch_get_main_queue() completion:^(id <ASImageContainerProtocol> imageContainer) { | |||
| [_cache cachedImageWithURL:imageURL callbackQueue:dispatch_get_main_queue() completion:^(id <ASImageContainerProtocol> imageContainer, BOOL isFromMemoryCache) { | |||
There was a problem hiding this comment.
Suggested change
| [_cache cachedImageWithURL:imageURL callbackQueue:dispatch_get_main_queue() completion:^(id <ASImageContainerProtocol> imageContainer, BOOL isFromMemoryCache) { | |
| [_cache cachedImageWithURL:imageURL callbackQueue:dispatch_get_main_queue() completion:^(id <ASImageContainerProtocol> imageContainer, __unused BOOL isFromMemoryCache) { |
There was a problem hiding this comment.
This actually wasn't the intention originally. The protocol is in place so any library can provide image downloading and caching either synchronously or asynchronously. It wasn't intended that Texture would know how the cache is backed. I'm guessing some coupling between PINRemoteImage and Texture has crept back in…
I would recommend reporting async / sync?
There was a problem hiding this comment.
@jparise Done
@garrettmoon Thanks for the context, have updated to use ansync/sync terminology.
jparise
approved these changes
Nov 6, 2019
garrettmoon
reviewed
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best as I can tell, a source type of
ASNetworkImageSourceAsynchronousCachewas meant to indicate a disk cache hit andASNetworkImageSourceSynchronousCachewas meant to indicate a memory cache hit. This change adds reporting of memory cache hits to the async rendering path.