Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pruning ASExperimentalRemoveTextKitInitialisingLock code. #1766

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Pruning ASExperimentalRemoveTextKitInitialisingLock code. #1766

merged 2 commits into from
Jan 28, 2020

Conversation

trufflin
Copy link
Contributor

The ASExperimentalRemoveTextKitInitialisingLock experimental code is unused; pruning.

@claassistantio
Copy link

claassistantio commented Jan 16, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

nguyenhuy
nguyenhuy approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trufflin for cleaning this up!

For reference, we decided to not restarting the experiment and accept that we still need to lock for the time being. More details regarding the crash when this lock is removed can be found in #1455.

@nguyenhuy nguyenhuy merged commit 70613a6 into TextureGroup:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenhuy nguyenhuy nguyenhuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@trufflin @claassistantio @nguyenhuy @rgupta-pinterest