Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Prevent crashing during non critical logging at rotation" #1772

Closed
wants to merge 1 commit into from

Conversation

raycsh017
Copy link
Contributor

Reverts #1770. Deferring the fix so we can find the root cause of the crash.

@foxware00
Copy link
Contributor

To add some details to this given you're wanting to find the root cause. Here is the stack trace of it happening. Unfortunately, I'm unable to share a demo project at the moment due to the complexity of the view in question. Please fire over any questions or anymore I can help with so we can get to the bottom of this.

(
	0   CoreFoundation                      0x00007fff23c7127e __exceptionPreprocess + 350
	1   libobjc.A.dylib                     0x00007fff513fbb20 objc_exception_throw + 48
	2   CoreFoundation                      0x00007fff23d03ab1 _CFThrowFormattedException + 194
	3   CoreFoundation                      0x00007fff23d0e4c6 -[__NSPlaceholderDictionary initWithObjects:forKeys:count:].cold.4 + 38
	4   CoreFoundation                      0x00007fff23cced97 -[__NSPlaceholderDictionary initWithObjects:forKeys:count:] + 247
	5   CoreFoundation                      0x00007fff23c6d12b +[NSDictionary dictionaryWithObjects:forKeys:count:] + 59
	6   AsyncDisplayKit                     0x000000010f5c94d3 NSStringFromASPrimitiveTraitCollection + 2579
	7   AsyncDisplayKit                     0x000000010f5e6acc -[ASViewController propagateNewTraitCollection:] + 444
	8   AsyncDisplayKit                     0x000000010f5e716c -[ASViewController didRotateFromInterfaceOrientation:] + 476
	9   UIKitCore                           0x00007fff47a42124 -[_UIViewControllerTransitionCoordinator _applyBlocks:releaseBlocks:] + 294
	10  UIKitCore                           0x00007fff47a3e1f2 -[_UIViewControllerTransitionContext _runAlongsideCompletions] + 126
	11  UIKitCore                           0x00007fff47a3df57 -[_UIViewControllerTransitionContext completeTransition:] + 104
	12  UIKitCore                           0x00007fff47a56865 __58-[_UIWindowRotationAnimationController animateTransition:]_block_invoke_2.186 + 26
	13  UIKitCore                           0x00007fff4856ff44 +[UIView(Internal) _performBlockDelayingTriggeringResponderEvents:forScene:] + 174
	14  UIKitCore                           0x00007fff47a56805 __58-[_UIWindowRotationAnimationController animateTransition:]_block_invoke.185 + 155
	15  UIKitCore                           0x00007fff4856b908 -[UIViewAnimationBlockDelegate _didEndBlockAnimation:finished:context:] + 671
	16  UIKitCore                           0x00007fff4853bf31 -[UIViewAnimationState sendDelegateAnimationDidStop:finished:] + 268
	17  UIKitCore                           0x00007fff4853c4a3 -[UIViewAnimationState animationDidStop:finished:] + 259
	18  QuartzCore                          0x00007fff2b14496c _ZN2CA5Layer23run_animation_callbacksEPv + 306
	19  libdispatch.dylib                   0x00007fff5223f7b9 _dispatch_client_callout + 8
	20  libdispatch.dylib                   0x00007fff5224bc9b _dispatch_main_queue_callback_4CF + 1212
	21  CoreFoundation                      0x00007fff23bd4049 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
	22  CoreFoundation                      0x00007fff23bceca9 __CFRunLoopRun + 2329
	23  CoreFoundation                      0x00007fff23bce066 CFRunLoopRunSpecific + 438
	24  GraphicsServices                    0x00007fff384c0bb0 GSEventRunModal + 65
	25  UIKitCore                           0x00007fff48092d4d UIApplicationMain + 1621
	26  Blink                               0x000000010dc9fa29 main + 233
	27  libdyld.dylib                       0x00007fff5227ec25 start + 1
	28  ???                                 0x0000000000000001 0x0 + 1
)

@bolsinga
Copy link
Contributor

no longer applicable.

@bolsinga bolsinga closed this May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants