Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve background color using system trait collection #1777

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

vovasty
Copy link
Contributor

@vovasty vovasty commented Feb 20, 2020

We should resolve color using node's trait collection, but Texture changes it from many places, so node may receive the wrong one.
This is a quick fix. We should revise trait collection propagation mechanism.

Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. For more context, we didn't resolve the background color from the node's trait collection before #1762 so this diff can be considered as a partial revert of #1762.

We still don't know why the trait collection never arrives at a valid value. We'll follow up to root cause it.

@nguyenhuy
Copy link
Member

CI is broken for some reasons. In previous runs, everything passed excepts Danger. Gonna land this diff now and figure out the CI issues later.

@nguyenhuy nguyenhuy merged commit 70f61e9 into TextureGroup:master Feb 21, 2020
@vovasty vovasty deleted the vlad/fix-color branch February 29, 2020 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants