Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASDisplayNode] Allow explicit setting of accessibilityElements #1807

Merged
merged 3 commits into from
Apr 24, 2020
Merged

[ASDisplayNode] Allow explicit setting of accessibilityElements #1807

merged 3 commits into from
Apr 24, 2020

Commits on Apr 22, 2020

  1. [ASDisplayNode] Allow explicit setting of accessibilityElements 

    Since `NSObject` conforms to the informal accessibility protocol, `ASDisplayNode` has an inherited property for `accessibilityElements`. However, setting this property has no effect since `ASDisplayNode` overrides the `accessibilityElements` getter. Added a small change to the getter to check if the `accessibilityElements` property on `ASDisplayNode` has been explicitly set, and if so return that.

I also added a comment around  `_ASDisplayView`’s `setAccessibilityElements:` method to clear up some (of my own) confusion.
    @rcancro
    rcancro committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    f9df765 View commit details
    Browse the repository at this point in the history

  2. comment tweak

    @rcancro
    rcancro committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    bbfb9ac View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. Fix flakey test

    @rcancro
    rcancro committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    4ad54a8 View commit details
    Browse the repository at this point in the history