-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate ASGraphicsCreateImageWithTraitCollectionAndOptions #1824
Closed
vovasty
wants to merge
22
commits into
TextureGroup:master
from
vovasty:vlad/deprecate-ASGraphicsCreateImageWithTraitCollectionAndOptions
Closed
deprecate ASGraphicsCreateImageWithTraitCollectionAndOptions #1824
vovasty
wants to merge
22
commits into
TextureGroup:master
from
vovasty:vlad/deprecate-ASGraphicsCreateImageWithTraitCollectionAndOptions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4797fed
to
04a3091
Compare
73b1037
to
f58c67d
Compare
bolsinga
approved these changes
May 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tests!
This has proven hard to maintain, and it has limited benefit now that our CHANGELOG points to GitHub commit ranges.
…tureGroup#1832) - I tried to make these tests work with OCMock, but that only ever saw 1 call. - All these do is count `-reloadData` calls. I'm not sure why so many other methods are recorded. - Why we are doing this is the library targets iOS 5 and is flagged as a warning in builds.
…AndOptions' of github.com:vovasty/Texture into vlad/deprecate-ASGraphicsCreateImageWithTraitCollectionAndOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #1814
Summary of changes:
ASGraphicsCreateImageWithTraitCollectionAndOptions
in favor ofASGraphicsCreateImage
ASGraphicsCreateImageWithTraitCollectionAndOptions
withASGraphicsCreateImage
traitCollection
parameter toUIImage_ASConvenience
and deprecate old onestraitCollection
parameter toasimagenode_modification_block_t
(without deprecation)UIImage_ASConvenience
ASImageNodeTintColorModificationBlock