Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Danger from the development workflow #1835

Merged
merged 1 commit into from
May 22, 2020
Merged

Remove Danger from the development workflow #1835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions .github/workflows/danger.yml
View file
Open in desktop

This file was deleted.

83 changes: 0 additions & 83 deletions Dangerfile
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions Gemfile
View file
Open in desktop

This file was deleted.

13 changes: 3 additions & 10 deletions build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function build_example {
example="$1"

clean_derived_data

if [ -f "${example}/Podfile" ]; then
echo "Using CocoaPods"
pod install --project-directory=$example
Expand Down Expand Up @@ -92,13 +92,6 @@ tests|all)
success="1"
;;

danger|all)
bundle install
echo "Running Danger..."
bundle exec danger --fail-on-errors=true
success="1"
;;

tests_listkit)
echo "Building & testing AsyncDisplayKit+IGListKit."
pod install --project-directory=SubspecWorkspaces/ASDKListKit
Expand Down Expand Up @@ -253,7 +246,7 @@ cocoapods-lint-other-subspecs)

carthage|all)
echo "Verifying carthage works."

set -o pipefail && carthage update && carthage build --no-skip-current
success="1"
;;
Expand All @@ -263,7 +256,7 @@ carthage|all)
;;
esac

if [ "$success" = "1" ]; then
if [ "$success" = "1" ]; then
trap - EXIT
exit 0
fi