Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate ASGraphicsCreateImageWithTraitCollectionAndOptions #1836

Conversation

vovasty
Copy link
Contributor

@vovasty vovasty commented May 22, 2020

This is a followup to #1814

Summary of changes:

  • deprecate ASGraphicsCreateImageWithTraitCollectionAndOptions in favor of ASGraphicsCreateImage
  • replace all occurrences of ASGraphicsCreateImageWithTraitCollectionAndOptions with ASGraphicsCreateImage
  • add new methods with traitCollection parameter to UIImage_ASConvenience and deprecate old ones
  • add traitCollection parameter to asimagenode_modification_block_t (without deprecation)
  • missing tests for UIImage_ASConvenience
  • missing tests for ASImageNodeTintColorModificationBlock
  • don't use deprecated methods in examples and documentation.

@vovasty vovasty requested a review from bolsinga May 22, 2020 23:35
@vovasty vovasty merged commit 74fd8f3 into TextureGroup:master May 23, 2020
piotrdebosz pushed a commit to getstoryteller/Texture that referenced this pull request Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants