Improve ThreeMigrationGuide.md #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jparise
reviewed
Jun 27, 2020
|
@jparise I don't understand how this PR is failing unit tests 🤔 are the tests broken in master as well? I think I don't have visibility into that |
varyP
pushed a commit
to varyP/Texture
that referenced
this pull request
Jul 3, 2020
* commit '1552c2e3865b1a872e30f647e7300fcccbf87d00': Upgrade to Xcode 11.5 (TextureGroup#1877) Renames AS_EXTERN and ASViewController (TextureGroup#1876) Improve ThreeMigrationGuide.md (TextureGroup#1878) Add a 3.0 migration guide (TextureGroup#1875) I forgot this in the last PR and I'm pushing to master, I'm a bad person. Update for 3.0.0-rc.2 (TextureGroup#1874) Update RELEASE.md (TextureGroup#1873) Fix all the warnings and re-enable on CI (TextureGroup#1872)
piotrdebosz
pushed a commit
to getstoryteller/Texture
that referenced
this pull request
Mar 1, 2021
* Add `ASImageCacherCompletion` breaking API change. * Remove unnecessary trailing pounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
ASImageCacherCompletionbreaking API change to the Texture 3.0 Migration Guide.This is the only point of contact that I had modify in order to make my project compile. It's not clear whether there're more changes or not, I can't easily tell without looking at the tens of PRs that got merged since 2.8.0 🙈
Texture 3.0 is now under QA process at Tellus and I'll keep this Migration Guide updated with any other internal details we find.
Thanks once again for pushing this release to the finish line :) it's been a long time! 😄
Cheers!