Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes a new option in ASImageDownloaderProtocol to retry image downloads #1948

Merged
merged 3 commits into from
Feb 19, 2021

Commits on Jan 22, 2021

  1. Exposes a new option in ASImageDownloaderProtocol to retry image down…

    …loads
    
    At the moment the ASBasicImageDownloader does not automatically retry image downloads if the remote
    host is unreachable. On the contrary the ASPINRemoteImageDownloader automatically retries. Retrying is
    something that ultimately clients need to be able to control, for example to fail fast to an alternative image
    rather than keep retrying for more than one minute while not displaying any image. This change exposes
    a new option in the ASImageDownloaderProtocol to retry image downloads. It also uses this new option
    in both ASNetworkImageNode and also ASMultiplexImageNode, setting it to YES to preserve the current
    behaviour.
    chggr committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    48bdb50 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82d0738 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. Fixes ScreenNode.m

    ScreenNode.m is implementing ASImageDownloaderProtocol and needs to
    be fixed to reflect changes in the latter.
    chggr committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    a43d579 View commit details
    Browse the repository at this point in the history