Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experiment to ensure ASCollectionView's range controller updates … #1976

Merged
merged 1 commit into from
Mar 25, 2021

Commits on Mar 25, 2021

  1. Add experiment to ensure ASCollectionView's range controller updates …

    …on changeset updates
    
    This experiment makes sure a ASCollectionView's `rangeController` updates when
    a changeset WITH updates is applied. Currently it is possible for nodes
    inserted into the preload range to not get preloaded when performing a batch
    update.
    
    For example, suppose a collection node has:
    - Tuning parameters with a preload range of 1 screenful for the given range
      mode.
    - Nodes A and B where A is visible and B is off screen.
    Currently if node B is deleted and a new node C is inserted in its place, node
    C will not get preloaded until the collection node is scrolled. This is because
    the preloading mechanism relies on a `setNeedsUpdate` call on the range
    controller as part of the `-collectionView:willDisplayCell:forItemAtIndexPath:`
    delegate method when the batch update is submitted. However, in the example
    outlined above, this sometimes doesn't happen automtically, causing the range
    update to be delayed until the next the view scrolls.
    rqueue committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    6b2f9a3 View commit details
    Browse the repository at this point in the history