Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASTextKitRenderer] Adding locking when accessing the text renderer cache #2075

Merged
merged 1 commit into from
Jan 25, 2023
Merged

[ASTextKitRenderer] Adding locking when accessing the text renderer cache #2075

merged 1 commit into from
Jan 25, 2023

Commits on Jan 24, 2023

  1. [ASTextKitRenderer] Adding locking when accessing the text renderer c… 

    …ache

While NSCache is thread safe, that alone does not make `rendererForAttributes` thread safe. This experiment will add a lock to `rendererForAttributes` to see how that affects performance/stability. As second experiment will forego the cache altogether to validate that we are getting some value out of having a renderer cache.
    @rcancro
    rcancro committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    deed9d1 View commit details
    Browse the repository at this point in the history