Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASCellNodeVisibilityEvent] Add a new event when scrolling stops #2084

Merged
merged 1 commit into from
Jul 26, 2023
Merged

[ASCellNodeVisibilityEvent] Add a new event when scrolling stops #2084

merged 1 commit into from
Jul 26, 2023

Commits on Jul 26, 2023

  1. [ASCellNodeVisibilityEvent] Add a new event when scrolling stops 

    We have `ASCellNodeVisibilityEvent` events that roughly correlate to the scrollViewDid… delegate methods in UIScrollView. With the current events we get a callback when a user stops dragging a cell, but if the cell decelerates we do not get an event when it comes to a rest. I’ve added  `ASCellNodeVisibilityEventDidStopScrolling` to have both `ASTableView` and `ASCollectionView` send this event to the cells in `_cellsForVisibilityUpdates` in `- (void)scrollViewDidEndDecelerating:(UIScrollView *)scrollView`.

I created unit tests to ensure that the proper events are being called for the proper scroll delegate methods.
    @rcancro
    rcancro committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    1167285 View commit details
    Browse the repository at this point in the history