[ASTextNode] Move to class method of drawRect:withParameters:isCancelled:isRasterizing: for drawing #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 CI failed with log |
Adlai-Holler
requested changes
May 4, 2017
Source/ASTextNode.mm
Outdated
| if (!UIEdgeInsetsEqualToEdgeInsets(_textContainerInset, UIEdgeInsetsZero)) { | ||
| drawParameters[ASTextNodeContainerInsetsDrawParameterKey] = [NSValue valueWithUIEdgeInsets:_textContainerInset]; | ||
| } | ||
| drawParameters[ASTextNodeRendererDrawParameterKey] = [self _rendererWithBoundsSlow:self.bounds]; |
There was a problem hiding this comment.
Getting this renderer is indeed slow so we shouldn't run it on the main thread – can we do one of these two things:
- Make a bigger change where
_rendererWithBoundsSlow:becomes a class method - Or make this a smaller change where we return
selffrom this method and use it in+drawRect:withParameters:(self)and update this implementation later.
maicki
changed the title
maicki
force-pushed
the
MSStaticDrawing
branch
2 times, most recently
from
7f75489
to
73416c0
Compare
Adlai-Holler
approved these changes
May 9, 2017
|
🚫 CI failed with log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our effort going forward to make the framework safer to work with and to enable future optimizations like lifting up caching into a generalized way out of
ASImageNodeandASTextNodespecific ways this PR will remove the instance version ofdrawRect:withParameters:isCancelled:isRasterizing:in favor of using the class method.