[ASDisplayNode] Pass drawParameter in rendering context callbacks

[maicki]

The reasoning for this change is that developers came up with all kinds of interesting ideas how to use properties in the ASDisplayNodeContextModifier blocks as it's running on non main properties like backgroundColor is not accessible. It is possible to access this properties on the main thread though and as we know drawParametersForAsyncLayer is called on main, developers can store this kind of properties within the draw parameters and use this in the ASDisplayNodeContextModifier blocks. To be able to do that we actually have to pass them in what this PR is planning to do.

This is basically an API breakage change and I'm happy to change if we would like to deprecate the old API and move over to this one, but as willDisplayNodeContentWithRenderingContext and didDisplayNodeContentWithRenderingContext is in the beta header I don't think we have to worry too much, furthermore it's not too hard to change to the new ASDisplayNodeContextModifier block as it's just adding a parameter.

[ghost]

🚫 CI failed with log

[ghost]

🚫 CI failed with log

[ghost]

🚫 CI failed with log

[ghost]

1 Warning

⚠️

Please ensure license is correct for LayoutExampleNodes.m: // // LayoutExampleNodes.m // Texture // // Copyright (c) 2014-present, Facebook, Inc. All rights reserved. // This source code is licensed under the BSD-style license found in the // LICENSE file in the /ASDK-Licenses directory of this source tree. An additional // grant of patent rights can be found in the PATENTS file in the same directory. // // Modifications to this file made after 4/13/2017 are: Copyright (c) 2017-present, // Pinterest, Inc. Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 //

Generated by 🚫 Danger

[Adlai-Holler]

Perfect! I agree let's not worry about the API change. Getting more immutable state captured into these draw parameters, and propagated to the asynchronous draw code safely is the name of the game. Land away!