Simplify Override Checking, Only Do It When Assertions Are Enabled #trivial #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
approved these changes
May 9, 2017
Adlai-Holler
changed the title
|
🚫 CI failed with log |
|
🚫 CI failed with log |
|
🚫 CI failed with log |
|
@Adlai-Holler Hey - the CI is currently failing, because if we build for release the
|
maicki
approved these changes
May 11, 2017
Adlai-Holler
force-pushed
the
AHSimplerInitialize
branch
from
02d0547
to
d8c81ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quickie.
[super initialize]. The runtime will traverse the class hierarchy for us.Method != Methodrather thanIMP != IMPbecause it's faster and simpler.