Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Layout] Extract layout implementation code into it's own subcategories #272

Merged
merged 4 commits into from
May 15, 2017

Conversation

maicki
Copy link
Contributor

@maicki maicki commented May 15, 2017

In our ongoing effort to make it easier to work on our code base, we move mostly all of the layout code implementation from ASDisplayNode into it's own categories.

@ghost
Copy link

ghost commented May 15, 2017

🚫 CI failed with log

@ghost
Copy link

ghost commented May 15, 2017

🚫 CI failed with log

@ghost
Copy link

ghost commented May 15, 2017

🚫 CI failed with log

@ghost
Copy link

ghost commented May 15, 2017

🚫 CI failed with log

@ghost
Copy link

ghost commented May 15, 2017

1 Warning
⚠️ This is a big PR, please consider splitting it up to ease code review.

Generated by 🚫 Danger

Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That's 900 lines closer to sanity!

@maicki maicki merged commit b32e69d into master May 15, 2017
@maicki maicki deleted the MSExtractLayoutCode branch September 8, 2018 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants