Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Unused Node Code #trivial #278

Merged
merged 1 commit into from
May 15, 2017
Merged

Remove Unused Node Code #trivial #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions Source/ASCollectionView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1968,16 +1968,6 @@ - (void)nodeDidInvalidateSize:(ASCellNode *)node
[self setNeedsLayout];
}

- (void)nodeDidRelayout:(ASCellNode *)node sizeChanged:(BOOL)sizeChanged
{
ASDisplayNodeAssertMainThread();

if (!sizeChanged) {
return;
}
[self nodesDidRelayout:@[node]];
}

- (void)nodesDidRelayout:(NSArray<ASCellNode *> *)nodes
{
ASDisplayNodeAssertMainThread();
Expand Down
15 changes: 0 additions & 15 deletions Source/ASTableView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1829,21 +1829,6 @@ - (void)nodeDidInvalidateSize:(ASCellNode *)node
[self setNeedsLayout];
}

- (void)nodeDidRelayout:(ASCellNode *)node sizeChanged:(BOOL)sizeChanged
{
ASDisplayNodeAssertMainThread();

if (!sizeChanged || _queuedNodeHeightUpdate || _remeasuringCellNodes) {
return;
}

_queuedNodeHeightUpdate = YES;
[self performSelector:@selector(requeryNodeHeights)
withObject:nil
afterDelay:0
inModes:@[ NSRunLoopCommonModes ]];
}

// Cause UITableView to requery for the new height of this node
- (void)requeryNodeHeights
{
Expand Down
13 changes: 0 additions & 13 deletions Source/Private/ASCellNode+Internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,6 @@ NS_ASSUME_NONNULL_BEGIN

@protocol ASCellNodeInteractionDelegate <NSObject>

/**
* Notifies the delegate that the specified cell node has done a relayout.
* The notification is done on main thread.
*
* This will not be called due to measurement passes before the node has loaded
* its view, even if triggered by -setNeedsLayout, as it is assumed these are
* not relevant to UIKit. Indeed, these calls can cause consistency issues.
*
* @param node A node informing the delegate about the relayout.
* @param sizeChanged `YES` if the node's `calculatedSize` changed during the relayout, `NO` otherwise.
*/
- (void)nodeDidRelayout:(ASCellNode *)node sizeChanged:(BOOL)sizeChanged;

/**
* Notifies the delegate that a specified cell node invalidates it's size what could result into a size change.
*
Expand Down