Ignore Relayout Requests for Deleted Cell Nodes #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deleted in the mean-time.
nguyenhuy
approved these changes
May 16, 2017
|
Since I can't see the crash report, I assume that is a known crash this change fixes? I'll try to test this fix today in my code. |
|
@jeffdav The stacktrace is very similar to yours. I believe they have the same root cause. |
|
Fix confirmed. Thank you. |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Data Controller: Ignore relayout requests for elements that have been deleted in the mean-time. * Bolster our logchange * Add sanity check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #277
As the data controller, it's fine to skip the layout. The cell node will either be deallocated, or it'll be hosted somewhere else and it'll get a new layout pass.