Fix Alignment of Hashed Structs #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
approved these changes
May 18, 2017
Adlai-Holler
added a commit
that referenced
this pull request
May 18, 2017
* Fix alignment of ASImageNodeContentsKey struct to fix hashing * Change the change log by logging a change * Add the world's stupidest explicit cast * Actually its simpler
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Fix alignment of ASImageNodeContentsKey struct to fix hashing * Change the change log by logging a change * Add the world's stupidest explicit cast * Actually its simpler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{ 7, 5, 3 }. When you do this, if the struct has padding, the memory contained in the padding bytes contains garbage.The solution is:
-Wpaddedwarning around structs that we use{}and subsequently hash.We could enable
-Wpaddedglobally but usually we don't care too much about padding so let's not do it for now.This patch is extremely important and should be released in a hotfix. The image cache hit rate before this patch is extremely low, at least on my mac.