[ASVideoNodeDelegate] fix for #291 crash #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ash an app because of not responding to selector; refs TextureGroup#291
nguyenhuy
approved these changes
May 18, 2017
Source/ASVideoNode.mm
Outdated
| @@ -58,6 +58,7 @@ @interface ASVideoNode () | |||
| unsigned int delegateVideoNodeDidSetCurrentItem:1; | |||
| unsigned int delegateVideoNodeDidStallAtTimeInterval:1; | |||
| unsigned int delegateVideoNodeDidRecoverFromStall:1; | |||
| unsigned int delegateVideoNodeDidFailToLoadValuesForKey:1; | |||
There was a problem hiding this comment.
Nit: delegateVideoNodeDidFailToLoadValueForKey, instead of delegateVideoNodeDidFailToLoadValuesForKey
|
Cool. Thanks for fixing this, @petrachkov! |
SergeyPetrachkov
added a commit
to SergeyPetrachkov/Texture
that referenced
this pull request
May 26, 2017
* Fixed bug where ASVideoNodeDelegate error reporting callback would crash an app because of not responding to selector; refs TextureGroup#291 * updated changelog.md * fixed typo in const name of ASVideoNodeDelegate method in delegate flags; refs TextureGroup#292
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Fixed bug where ASVideoNodeDelegate error reporting callback would crash an app because of not responding to selector; refs TextureGroup#291 * updated changelog.md * fixed typo in const name of ASVideoNodeDelegate method in delegate flags; refs TextureGroup#292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #291.