Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] Fixed crash on SocialAppLayout-Inverted + behaviour comments #304

Merged
merged 3 commits into from
May 24, 2017

Conversation

dimazen
Copy link

@dimazen dimazen commented May 24, 2017

No description provided.

Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after CI passes. Thanks @dimazen for the fix!

@dimazen
Copy link
Author

dimazen commented May 24, 2017

@maicki Hello! It looks like that CI/Pinterest is awaiting for the build approval. I believe this is due to incorrect header file in the sample app that was mentioned originally by the Danger. It seems to have an old format.

@dimazen
Copy link
Author

dimazen commented May 24, 2017

I've updated license header for all of the files in the SocialAppLayout-Inverted to conform to the Danger requirements

@Adlai-Holler
Copy link
Member

Sweet! Here we go!

@Adlai-Holler Adlai-Holler merged commit caa7e2e into TextureGroup:master May 24, 2017
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
…ts (TextureGroup#304)

* [Examples] Fixed crash on SocialAppLayout-Inverted + behaviour comments

* [Examples] Update license header in SocialAppLayout-Inverted to the correct format

* [Examples] License header typo fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants