[Yoga] Refer to proper path name and use module import #306
Conversation
|
|
|
🚫 CI failed with log |
weibel
changed the title
weibel
changed the title
| @@ -33,7 +33,7 @@ | |||
| // If Yoga is available, make it available anywhere we use ASAvailability. | |||
| // This reduces Yoga-specific code in other files. | |||
| #ifndef YOGA_HEADER_PATH | |||
| #define YOGA_HEADER_PATH <Yoga/Yoga.h> | |||
| #define YOGA_HEADER_PATH <yoga/Yoga.h> | |||
There was a problem hiding this comment.
This change definitely seems correct, and we should merge it.
Source/ASDisplayNode+Beta.h
Outdated
| @@ -21,7 +21,7 @@ | |||
| #import <AsyncDisplayKit/ASEventLog.h> | |||
|
|
|||
| #if YOGA | |||
| #import YOGA_HEADER_PATH | |||
| @import yoga; | |||
There was a problem hiding this comment.
I would like to avoid this change if possible. Does your error still occur if this is not changed? Can you screenshot the error / warning that you get without this change, but with the HEADER_PATH change?
The reason we'd like to avoid this is that some build systems do not support @import. It would be the only usage in the entire framework, and I believe it should be possible to make this work reliably without using @import.
|
@weibel I'd love to hear back from you on this one, but for now I've removed the module change (since it breaks some build systems including the one I'm using). I think the other change should be sufficient to fix your issue as it corrects the capitalization problem, but please let us know what the error is that you're seeing if this doesn't work. |
Generated by 🚫 Danger |
) * Change header path to fix TextureGroup#25 * Use module import * Update ASDisplayNode+Beta.h
Fixes #25