[ASDisplayNode] Revise assertion to log until Issue #145 is addressed. #trivial #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For apps that include pre-existing calls to reloadData, this assertion has made development difficult on all recent versions of Texture. Since triggering it can't be reliably used as signal by the app developer, and halts a development session (sometimes immediately on app start), it should be disabled until it is reliable again. See issue #145 for details.
Generated by 🚫 Danger |
nguyenhuy
approved these changes
May 29, 2017
appleguy
changed the title
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…is addressed. (TextureGroup#313) [ASDisplayNode] Revise assertion to log until Issue TextureGroup#145 is addressed. #trivial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For apps that include pre-existing calls to reloadData, this assertion has made
development difficult on all recent versions of Texture.
Since triggering it can't be reliably used as signal by the app developer, and
halts a development session (sometimes immediately on app start), it should be
disabled until it is reliable again.
See issue #145 for details. cc @Adlai-Holler, @garrettmoon
Ideally we'd push a release shortly after taking this change, as the issue has been widely reported in the community. There's no known workaround besides modifying the local copy of Texture with a change like this, and local diffs discourage updating.