Clean Up ASAsyncTransaction #trivial #316
Conversation
Generated by 🚫 Danger |
Adlai-Holler
changed the title
| @@ -445,7 +432,8 @@ - (void)addOperationWithBlock:(asyncdisplaykit_async_transaction_operation_block | |||
| - (void)addCompletionBlock:(asyncdisplaykit_async_transaction_completion_block_t)completion | |||
| { | |||
| __weak __typeof__(self) weakSelf = self; | |||
| [self addOperationWithBlock:^(){return (id<NSObject>)nil;} queue:_callbackQueue completion:^(id<NSObject> value, BOOL canceled) { | |||
| dispatch_queue_t bsQueue = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0); | |||
| [self addOperationWithBlock:^(){return (id)nil;} queue:bsQueue completion:^(id value, BOOL canceled) { | |||
There was a problem hiding this comment.
I bet the (id)nil cast isn't needed anymore.
There was a problem hiding this comment.
Surprisingly it is! The compiler inferred nullptr instead of (id)nil when I just put nil. Bizarre I know =/
| @@ -445,7 +432,8 @@ - (void)addOperationWithBlock:(asyncdisplaykit_async_transaction_operation_block | |||
| - (void)addCompletionBlock:(asyncdisplaykit_async_transaction_completion_block_t)completion | |||
| { | |||
| __weak __typeof__(self) weakSelf = self; | |||
| [self addOperationWithBlock:^(){return (id<NSObject>)nil;} queue:_callbackQueue completion:^(id<NSObject> value, BOOL canceled) { | |||
| dispatch_queue_t bsQueue = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0); | |||
There was a problem hiding this comment.
wtf does bsQueue mean? lol
Either way, shouldn't this operation be called on the main queue, if _callbackQueue used to be main? This seems like it might be a behavior change.
There was a problem hiding this comment.
bsQueue means "bullshit queue." The completion will be called on main still, but the bs "work" that we submitted should be done on another queue. If we try to do the work on the main queue, the transaction won't be safe to wait on (the group will get stuck.)
This method isn't currently used and I'd be glad to remove it. Thoughts?
idrather thanid<NSObject>.id<NSObject>can be a pain to deal with since it can't be implicitly cast, plus it's ugly.callbackQueue.callbackQueue.atomicsince it's set from background thread, but read from main thread.