Rejigger Cell Visibility Tracking #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 CI failed with log |
appleguy
approved these changes
May 30, 2017
There was a problem hiding this comment.
@Adlai-Holler this is a nontrivial patch! Thanks for creating it on a holiday!
Everything here looks good to me. I think we should land this and push out a release as soon as practical, although we might want to get additional reviews (e.g. from @nguyenhuy) or at least get a certain pure-Texture app running against it to look for any subtle issues :).
| [_rangeController setNeedsUpdate]; | ||
| return; | ||
| } | ||
| auto cell = (_ASCollectionViewCell *)rawCell; |
Generated by 🚫 Danger |
|
Super :) Ok
Spark by Readdle
|
|
Let's land this and get it tested. I'll keep an eye on its behavior and fix any regressions. |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Rejigger visible elements tracking * Put the assertion back * Remove unused stuff * Make it stronk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #145 . I never had a reliable repro for it, so I'm counting on the community to test this patch.
willDisplayCellanddidEndDisplayingCellare the authoritative sources for what elements are visible. Elements may be visible in multiple cells e.g. during animations, so we use a counted set.(weak)_ASCollectionViewCell.nodewith(strong)_ASCollectionViewCell.element.NSCountedSet<ASCollectionElement *> *_visibleElementsto collection view.willDisplayCell:anddidEndDisplayingCell:, add/remove the cell's element from the visible set.visibleElementsForRangeController:to just return a copy of this set.