1st prototype of Texture debugger #339
Conversation
|
🚫 CI failed with log |
|
🚫 CI failed with log |
- Client apps connect to Chrome DevTools via ponyd server. Setup instructions coming. - Users can highlight display nodes as well as layout specs. - Style and other useful properties will be exposed later on.
nguyenhuy
force-pushed
the
HNLayoutDebugger-PR
branch
from
bceedc6
to
99162ed
Compare
Generated by 🚫 Danger |
|
🚫 CI failed with log |
|
|
||
| - (CGRect)td_frameInWindow | ||
| { | ||
| return [self convertRect:self.bounds toLayer:nil]; |
There was a problem hiding this comment.
I could be wrong, but I don't think this is actually correct for layers, only views? There's nothing in the documentation that it coverts to window for CALayer. In fact what it says is super opaque:
If you specify nil for the l parameter, this method returns the original rect with an origin added to the layer's frame's origin.
I don't know what origin is… perhaps it's based on the window…
There was a problem hiding this comment.
Hm, you're right. Let me revisit this!
| @@ -1,6 +1,8 @@ | |||
| source 'https://github.com/CocoaPods/Specs.git' | |||
| platform :ios, '8.0' | |||
| target 'Sample' do | |||
| pod 'Texture/IGListKit', :path => '../..' | |||
| pod 'Texture/PINRemoteImage', :path => '../..' | |||
| pod 'PonyDebugger', :git => 'https://github.com/nguyenhuy/PonyDebugger.git', :branch => 'master' | |||
There was a problem hiding this comment.
Just to be clear, the endgame is not to have people point to a fork in the end?
There was a problem hiding this comment.
Once we completely fork PonyDebugger and publish a TextureDebugger pod, this will be unnecessary.
|
CI is failing at |
|
Closing this in favor of a separate repo for the debugger here. |
Author: Thanh Huy Nguyen
This PR depends on #337. Please review #337 first.