-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1st prototype of Texture debugger #339
Conversation
🚫 CI failed with log |
🚫 CI failed with log |
- Client apps connect to Chrome DevTools via ponyd server. Setup instructions coming. - Users can highlight display nodes as well as layout specs. - Style and other useful properties will be exposed later on.
bceedc6
to
99162ed
Compare
Generated by 🚫 Danger |
🚫 CI failed with log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, so exciting!
|
||
- (CGRect)td_frameInWindow | ||
{ | ||
return [self convertRect:self.bounds toLayer:nil]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could be wrong, but I don't think this is actually correct for layers, only views? There's nothing in the documentation that it coverts to window for CALayer. In fact what it says is super opaque:
If you specify nil for the l parameter, this method returns the original rect with an origin added to the layer's frame's origin.
I don't know what origin is… perhaps it's based on the window…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, you're right. Let me revisit this!
@@ -1,6 +1,8 @@ | |||
source 'https://github.com/CocoaPods/Specs.git' | |||
platform :ios, '8.0' | |||
target 'Sample' do | |||
pod 'Texture/IGListKit', :path => '../..' | |||
pod 'Texture/PINRemoteImage', :path => '../..' | |||
pod 'PonyDebugger', :git => 'https://github.com/nguyenhuy/PonyDebugger.git', :branch => 'master' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be clear, the endgame is not to have people point to a fork in the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we completely fork PonyDebugger and publish a TextureDebugger pod, this will be unnecessary.
CI is failing at |
Closing this in favor of a separate repo for the debugger here. |
Author: Thanh Huy Nguyen
This PR depends on #337. Please review #337 first.