Add first-pass view model support to collection node. #trivial #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
commented
Jun 12, 2017
| @@ -207,6 +207,7 @@ @interface ASCollectionView () <ASRangeControllerDataSource, ASRangeControllerDe | |||
| unsigned int collectionViewNumberOfItemsInSection:1; | |||
| unsigned int collectionNodeNodeForItem:1; | |||
| unsigned int collectionNodeNodeBlockForItem:1; | |||
| unsigned int viewModelForItem:1; | |||
There was a problem hiding this comment.
No prefix needed for this method, since there's no collectionNode/collectionView distinction this time.
Adlai-Holler
changed the title
|
🚫 CI failed with log |
garrettmoon
approved these changes
Jun 12, 2017
Source/ASCellNode.h
Outdated
| * | ||
| * The view-model currently assigned to this node, if any. | ||
| * | ||
| * This property may be set off the main thread, but it will never be set in parallel. |
There was a problem hiding this comment.
Can you explain further what you mean "it will never be set in parallel"?
nguyenhuy
approved these changes
Jun 12, 2017
|
@nguyenhuy For these changes I'd rather have smaller, simpler diffs and I don't see much drawback to it. |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…reGroup#356) * Add first-pass view model support for collection node. Much more to come! * Address issues * Update the gorram license header * Dear lord
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of a series of diffs I intend to land over the next couple of days, adding support for view-model backed cell nodes, and eventually optional view-model diffing to drive updates.
There's not much to this first pass. You can provide view models, and they'll get assigned to the cell node and made available by the collection node.
The next pass will add the idea of
-canUpdateToViewModel:and skip fetching a new node block onreloadItemsAtIndexPaths:if the existing cell node can update.I'll update the CHANGELOG when something more significant happens.