[ASTableView] Use ASTableView tableNode property instead of calling ASViewToDisplayNode #trivial #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
maicki
changed the title
maicki
changed the title
|
Cool thanks. |
appleguy
approved these changes
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are accessing the
tableNodeproperty inASTableViewin the batch fetching mechanism on a background thread. The problem is that we overwrite thetableNodeaccessor and callingASViewToDisplayNodewhat will access theASTableViewon a background thread.With Xcode 9 Apple added the Main Thread Checker and it will catch this issue. You can try it out within the Kittens example.
Fixes the report from @WymzeeLabs in #345