Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates ASDKGram to use IGListKit 3.0.0 #367

Merged
merged 1 commit into from
Jun 18, 2017

Conversation

ay8s
Copy link
Collaborator

@ay8s ay8s commented Jun 17, 2017

Spotted #364 asking for an update to support IGListKit 3.0.0. This simply gets ASDKGram updated to use IGListKit 3.0.0, it doesn't make any drastic changes to make use of any of the new stuff added in IGListKit.

We've been using 3.0.0 within Buffer alongside Texture for a couple of releases without any issues.

Worth noting I tweaked the podspec and podfile. Wasn't sure how best to handle that & can totally adjust if needed until a future release of Texture.

@CLAassistant
Copy link

CLAassistant commented Jun 17, 2017

CLA assistant check
All committers have signed the CLA.

@ay8s ay8s mentioned this pull request Jun 17, 2017
Copy link
Member

@appleguy appleguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you @ay8s!

@appleguy
Copy link
Member

@garrettmoon is it possible to restart the build for this PR? It seems like it probably won't finish.

@ghost
Copy link

ghost commented Jun 18, 2017

4 Warnings
⚠️ Please ensure license is correct for ASCollectionSectionController.m:

//
//  ASCollectionSectionController.m
//  Texture
//
//  Copyright (c) 2014-present, Facebook, Inc.  All rights reserved.
//  This source code is licensed under the BSD-style license found in the
//  LICENSE file in the /ASDK-Licenses directory of this source tree. An additional
//  grant of patent rights can be found in the PATENTS file in the same directory.
//
//  Modifications to this file made after 4/13/2017 are: Copyright (c) 2017-present,
//  Pinterest, Inc.  Licensed under the Apache License, Version 2.0 (the "License");
//  you may not use this file except in compliance with the License.
//  You may obtain a copy of the License at
//
//      http://www.apache.org/licenses/LICENSE-2.0
//

    
⚠️ Please ensure license is correct for PhotoFeedListKitViewController.m:

//
//  PhotoFeedListKitViewController.m
//  Texture
//
//  Copyright (c) 2014-present, Facebook, Inc.  All rights reserved.
//  This source code is licensed under the BSD-style license found in the
//  LICENSE file in the /ASDK-Licenses directory of this source tree. An additional
//  grant of patent rights can be found in the PATENTS file in the same directory.
//
//  Modifications to this file made after 4/13/2017 are: Copyright (c) 2017-present,
//  Pinterest, Inc.  Licensed under the Apache License, Version 2.0 (the "License");
//  you may not use this file except in compliance with the License.
//  You may obtain a copy of the License at
//
//      http://www.apache.org/licenses/LICENSE-2.0
//

    
⚠️ Please ensure license is correct for PhotoFeedSectionController.h:

//
//  PhotoFeedSectionController.h
//  Texture
//
//  Copyright (c) 2014-present, Facebook, Inc.  All rights reserved.
//  This source code is licensed under the BSD-style license found in the
//  LICENSE file in the /ASDK-Licenses directory of this source tree. An additional
//  grant of patent rights can be found in the PATENTS file in the same directory.
//
//  Modifications to this file made after 4/13/2017 are: Copyright (c) 2017-present,
//  Pinterest, Inc.  Licensed under the Apache License, Version 2.0 (the "License");
//  you may not use this file except in compliance with the License.
//  You may obtain a copy of the License at
//
//      http://www.apache.org/licenses/LICENSE-2.0
//

    
⚠️ Please ensure license is correct for RefreshingSectionControllerType.h:

//
//  RefreshingSectionControllerType.h
//  Texture
//
//  Copyright (c) 2014-present, Facebook, Inc.  All rights reserved.
//  This source code is licensed under the BSD-style license found in the
//  LICENSE file in the /ASDK-Licenses directory of this source tree. An additional
//  grant of patent rights can be found in the PATENTS file in the same directory.
//
//  Modifications to this file made after 4/13/2017 are: Copyright (c) 2017-present,
//  Pinterest, Inc.  Licensed under the Apache License, Version 2.0 (the "License");
//  you may not use this file except in compliance with the License.
//  You may obtain a copy of the License at
//
//      http://www.apache.org/licenses/LICENSE-2.0
//

    

Generated by 🚫 Danger

@nguyenhuy
Copy link
Member

The build was waiting for approval. It should proceed now.

@appleguy appleguy merged commit 46c4359 into TextureGroup:master Jun 18, 2017
@ghost
Copy link

ghost commented Dec 14, 2017

Hello, why does ASDKGram need ASCollectionSectionController instead using performUpdates from IGListKit?

bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants